gsmiller commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r745147108
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java
##########
@@ -41,12 +40,7 @@ public DocValuesOrdinalsReader(String field) {
@Override
public OrdinalsSegmentReader getReader(LeafReaderContext context) throws
IOException {
Review comment:
I ended up keeping support for OrdinalsReader so that users can provide
their own source of ordinals in custom cases, but have moved all the default
faceting logic over to use the doc values field directly instead of this
OrdinalsReader indirection (except in a couple cases to maintain back-compat).
So I think I've gotten at the core issue/suggestion here, but certainly open to
more suggestions or feeback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
