rmuir commented on pull request #466:
URL: https://github.com/apache/lucene/pull/466#issuecomment-976527314


   @dweiss I considered dedicated test group as well, but I like the `@Nightly` 
solution that keeps it simple and doesn't add more test groups :). 
   
   In fact, we may want to look into GC'ing test groups such as `@BadApple` 
that lucene is not using. I am also suspicious of the value we get from 
`@Slow`: they are enabled by default, hence such tests run everywhere by 
default (PR checks, ordinary jenkins builds), so personally i'd never risk 
turning them off only to see a code change immediately fail.
   
   On the other hand, `@Nightly` seems appropriate and useful for this 
situation, most code changes honestly don't impact the index format. If you are 
making an index format change, it is typically a significant effort anyway, no 
big deal to just turn on nightly too before making a PR, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to