rmuir commented on pull request #466: URL: https://github.com/apache/lucene/pull/466#issuecomment-976572901
Interesting, I agree with that. I personally really do try to avoid just "tossing tests under the rug" to Nightly when working on the tests performance. To me it is the last resort, they are a necessary? evil. I'd rather that we have fast tests organized in a simple system that everyone understands, e.g. no surprises where a PR build fails but things passed for the contributor locally, no surprises where a nightly build fails after a PR build succeeded, etc. Often times it is just so easy to fix the tests in another way: less iterations, less threads (only max 2 should ever be needed IMO), less documents, etc etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
