uschindler commented on pull request #473: URL: https://github.com/apache/lucene/pull/473#issuecomment-979243665
Hi, this looks good to me. I am a bit hesitant about Version.getImplementationVersion(), as the Version class also has a LATEST and CURRENT_VERSION symbol. Mabye rename Version.getPackageImplementationVersion(). But I am happy of the functionality, but because of this as a new API addition, we should think about naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
