uschindler commented on pull request #473: URL: https://github.com/apache/lucene/pull/473#issuecomment-979308132
Hi Dawid, i think the important thing was in former days of Luke to see the implementation version of lucene-core.jar. Also other projects like Elasticsearch or Solr want to show this. So I think the method in Version is fine. We should at least add a cahenges entry that we removed the LucenePackage class and added a implementation version getter in lucene's core. About luke: Of course luke could only show its version, but for the reasons above i tend to think that we should provide a way for external projects to show the lucene version they are linking to. I think code is same, but having a Version.getImplementationVersion() is a good idea to have. We provided it for years (since Lucene v1.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
