mikemccand commented on a change in pull request #485:
URL: https://github.com/apache/lucene/pull/485#discussion_r762124349
##########
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##########
@@ -65,7 +63,7 @@
* @param automaton Automaton to run, terms that are accepted are considered
a match.
*/
public AutomatonQuery(final Term term, Automaton automaton) {
Review comment:
I like this approach! +1 to let the more friendly `AutomatonQuery`
subclasses control this, if appropriate. E.g. for `PrefixQuery` and
`WildcardQuery`, determinize is very low risk and probably a good idea.
`FuzzyQuery` [already makes a deterministic automaton,
phew](https://blog.mikemccandless.com/2011/03/lucenes-fuzzyquery-is-100-times-faster.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
