gf2121 commented on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999377609
@jpountz Thanks a lot for the suggestion! > Let's update this pull request to limit the impact to the API to DirectMonotonicReader, since it's the only LongValues impl where we ever need to read two consecutive values at the same time? Actually, DirectMonotonicReader is not the only impl using this, line 176 in `DirectMonotonicReader` could call the `DirectReader#get(index, twin)` . I tried to limit the change to `DirectMonotonicReader`, and the luceneUtil shows the QPS increasing (mentioned in jira) decreased from 20%+ to around 7%. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
