rmuir commented on a change in pull request #590:
URL: https://github.com/apache/lucene/pull/590#discussion_r780229999
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/core/DecimalDigitFilter.java
##########
@@ -35,6 +35,7 @@ public DecimalDigitFilter(TokenStream input) {
}
@Override
+ @SuppressWarnings("CharacterGetNumericValue") // we use
Character.isDigit(ch), so it is safe
Review comment:
I just asked to ban this check because it adds useless noise. I'm not a
fan of these kinds of error-prone checks that have a high false-positive rate.
IMO, if we consider methods a trap, I'd rather use forbidden-apis. And if we
want to lint the code, we should crank up javac and ecj warnings (there are
still stuff there we can enable).
It is unclear to me where error-prone fits in... but let's be selective
about which of its crazy heuristical checks gets applied? If there are ones
that truly find bugs, that's different than if we are just making our build
system annoying and fighting the developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
