rmuir commented on a change in pull request #590:
URL: https://github.com/apache/lucene/pull/590#discussion_r780235407
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/core/DecimalDigitFilter.java
##########
@@ -35,6 +35,7 @@ public DecimalDigitFilter(TokenStream input) {
}
@Override
+ @SuppressWarnings("CharacterGetNumericValue") // we use
Character.isDigit(ch), so it is safe
Review comment:
I'm just arguing that this particular check isn't useful.
It is "dumb" in that it seems to just fail if you use the method at all:
https://github.com/google/error-prone/blob/master/core/src/main/java/com/google/errorprone/bugpatterns/CharacterGetNumericValue.java
It doesn't do any "real analysis" to see if e.g. code is guarded by
`Character.isDigit` check or similar.
Again, if we want to ban methods outright, i'd rather use forbidden APIs. It
is a million times faster, and it runs non-nightly and is more friendly to the
developers. Separately, I don't think this particular method needs to be banned
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
