jtibshirani commented on pull request #617: URL: https://github.com/apache/lucene/pull/617#issuecomment-1017979480
Some notes: * The HNSW format no longer needs the ability to override `merge`. It's still possible though -- it seems like helpful flexibility and there's precedent with other formats. * We still can't remove `RandomAccessVectorValues` or make it package-private to HNSW. This is because `SortingVectorValues` assumes its input supports random access. We can improve this later as part of [LUCENE-9583](https://issues.apache.org/jira/browse/LUCENE-9583). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
