jpountz commented on a change in pull request #617:
URL: https://github.com/apache/lucene/pull/617#discussion_r790115140
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsWriter.java
##########
@@ -114,79 +113,15 @@
public void writeField(FieldInfo fieldInfo, KnnVectorsReader
knnVectorsReader)
throws IOException {
long vectorDataOffset = vectorData.alignFilePointer(Float.BYTES);
-
VectorValues vectors = knnVectorsReader.getVectorValues(fieldInfo.name);
- // TODO - use a better data structure; a bitset? DocsWithFieldSet is p.p.
in o.a.l.index
Review comment:
nit: can you retain that TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
