[
https://issues.apache.org/jira/browse/LUCENE-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482067#comment-17482067
]
Greg Miller commented on LUCENE-10368:
--------------------------------------
[~gf2121] any thoughts on these PRs? Do you think this approach makes sense to
reduce the visibility of {{{}IntTaxonomyFacets{}}}? (No rush on this...
whenever you have a couple minutes to take a look is great)
> Reduce visibility of IntTaxonomyFacets
> --------------------------------------
>
> Key: LUCENE-10368
> URL: https://issues.apache.org/jira/browse/LUCENE-10368
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Assignee: Greg Miller
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Opening this issue as a follow up from the conversation over here:
> [https://github.com/apache/lucene/pull/578#discussion_r779353869]
> I'd propose we reduce the visibility to {{pkg-private}} and do a little
> cleanup. This is essentially indicating that {{IntTaxonomyFacets}} is an
> internal implementation detail of taxonomy faceting (shared common logic) as
> opposed to an intentional extension point for users.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
