gf2121 commented on a change in pull request #600:
URL: https://github.com/apache/lucene/pull/600#discussion_r792359628
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##########
@@ -62,8 +52,82 @@ protected IntTaxonomyFacets(
}
}
+ /** Rolls up any single-valued hierarchical dimensions. */
+ void rollup() throws IOException {
Review comment:
Thanks for the explaination!
I'm not very sure if we need to sperate into two conditions earlier here, as
it seems this is causing some more duplicated codes but there should not be too
many elements in `config.getDimConfigs().entrySet()` (Checking in each round
should be cheap). Maybe we can keep it simple here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
