[
https://issues.apache.org/jira/browse/LUCENE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492890#comment-17492890
]
Greg Miller commented on LUCENE-10398:
--------------------------------------
OK, after looking over the PR, I'm back to liking this idea :) Looks like it
allowed null checks to be removed in a number of places, which is nice. I'm in
favor of this and left some minor comments on the PR, but I'm curious if anyone
else feels like the API shouldn't be added for any particular reason. Thanks
again [~spike.liu] for picking this up!
> Add static method for getting Terms from LeafReader
> ---------------------------------------------------
>
> Key: LUCENE-10398
> URL: https://issues.apache.org/jira/browse/LUCENE-10398
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Marc D'Mello
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hi all, {{LeafReader}} has methods like {{getBinaryDocValues(String field)}}
> that return {{null}} values if the field is not indexed. These methods also
> have equivalent {{DocValues}} static methods, such as
> {{DocValues.getBinary()}}, which return an {{emptyBinary()}} rather than a
> {{null}} if there is no field. I noticed that {{Terms}} does not have an
> equivalent static method for {{LeafReader.terms()}} like {{Terms.terms()}} or
> something similar. I was wondering if there was a reason for this, or if a
> method like this could be useful. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
