gsmiller commented on pull request #678: URL: https://github.com/apache/lucene/pull/678#issuecomment-1041899789
Thanks for the quick iteration! This looks good to me now. As I mentioned before, I'm going to wait a couple days before merging in case anyone else wants to chime in with feedback or opposition to adding this functionality, but I'd consider this ready to go from my perspective. As a side note, in the future, it makes it a little easier to review if you avoid force pushing changes and leave the git commit history in place. That way I can easily look at what's changed since I last reviewed. I know a lot of people are in the habit of squashing commit history to keep it clean, but github makes that super easy to do when actually merging your pull request, so no need to do that on your side. Just a future note. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
