rmuir commented on a change in pull request #722:
URL: https://github.com/apache/lucene/pull/722#discussion_r817992391



##########
File path: lucene/core/src/java/org/apache/lucene/search/RegexpQuery.java
##########
@@ -62,6 +62,24 @@ public RegexpQuery(Term term) {
     this(term, RegExp.ALL);
   }
 
+  /**
+   * Constructs a query for terms matching <code>term</code>.
+   *
+   * <p>By default, all regular expression features are enabled.
+   *
+   * @param term regular expression.
+   * @param rewriteMethod the rewrite method used to build the final query
+   */
+  public RegexpQuery(Term term, RewriteMethod rewriteMethod) {
+    this(
+        term,
+        RegExp.ALL,
+        0,
+        defaultProvider,
+        Operations.DEFAULT_DETERMINIZE_WORK_LIMIT,
+        rewriteMethod);
+  }
+

Review comment:
       same thing here. let's not add it to all these "sugar" ctors. Its enough 
to add it to the one "full" ctor 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to