mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1071100941
About the increased number of lines, the majority of them are license headers and documentation. There are added 22 files (to sort out interfaces) and removed 4 files - each license header contains 15 lines so 288 license headers are added. Another reason for increasing the number of lines is newly introduced interfaces and their Javadocs. I think the substantial amount of code of the implementation classes was reduced by this change, though, I didn't count it. I think the apparent demerit of this patch is exposing dictionary internals as public interfaces (and kuromoji and nori depend on it). We would have to choose which is better - keep hiding internals and maintain duplicated code, or open up some internals and share them. I myself would prefer the latter approach to ease the development or bug fixes that are common to kuromoji and nori, and prevent further diversifying them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
