jpountz commented on code in PR #780:
URL: https://github.com/apache/lucene/pull/780#discussion_r842415780


##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -94,6 +95,7 @@ public void disableSkipping() {
     private long iteratorCost;
     private int maxDocVisited = -1;
     private int updateCounter = 0;
+    private boolean disableSegmentInternalSkip = false;

Review Comment:
   Thanks, I had missed this. In my opinion, this adds too much complexity for 
the problem that it is solving. I think we should either accept the skipping 
overhead even though skipping won't help much, or disable skipping entirely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to