rmuir commented on code in PR #827:
URL: https://github.com/apache/lucene/pull/827#discussion_r856168982
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##########
@@ -1112,12 +1112,17 @@ public void seekExact(long ord) throws IOException {
throw new IndexOutOfBoundsException();
}
final long blockIndex = ord >>> TERMS_DICT_BLOCK_LZ4_SHIFT;
- final long blockAddress = blockAddresses.get(blockIndex);
- bytes.seek(blockAddress);
- this.ord = (blockIndex << TERMS_DICT_BLOCK_LZ4_SHIFT) - 1;
- do {
+ final long currentBlockIndex = this.ord >>> TERMS_DICT_BLOCK_LZ4_SHIFT;
Review Comment:
i don't understand the new logic. i've stared hard at it multiple times. I'm
concerned we create a situation where advance() gets translated into waaaaay
too many next() calls. no test will catch this, it would just be slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
