rmuir commented on code in PR #827:
URL: https://github.com/apache/lucene/pull/827#discussion_r856173930
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##########
@@ -1112,12 +1112,17 @@ public void seekExact(long ord) throws IOException {
throw new IndexOutOfBoundsException();
}
final long blockIndex = ord >>> TERMS_DICT_BLOCK_LZ4_SHIFT;
- final long blockAddress = blockAddresses.get(blockIndex);
- bytes.seek(blockAddress);
- this.ord = (blockIndex << TERMS_DICT_BLOCK_LZ4_SHIFT) - 1;
- do {
+ final long currentBlockIndex = this.ord >>> TERMS_DICT_BLOCK_LZ4_SHIFT;
Review Comment:
honestly, for me, I thought the first way you had it was very easy to read
and see the correctness. it just needed to change `>>>` to `>>` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
