[ 
https://issues.apache.org/jira/browse/LUCENE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528821#comment-17528821
 ] 

ASF subversion and git services commented on LUCENE-10525:
----------------------------------------------------------

Commit a6be6ae29d6a8cc9d8a69df5b6af6ce4b6c77557 in lucene's branch 
refs/heads/branch_9x from Gautam Worah
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=a6be6ae29d6 ]

LUCENE-10525 Improve WindowsFS emulation to catch invalid file names (#829)

* Add filename checks for WindowsFS
* don't delegate Path default methods, which makes it easier for subclassing. 
Also fix delegation bug (endsWith was calling startsWith).


> Improve WindowsFS emulation to catch directory names with : in them (which is 
> not allowed) 
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10525
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Gautam Worah
>            Priority: Minor
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> In PR ([https://github.com/apache/lucene/pull/762)] we missed the case where 
> a tempDir name was using `:` in the dir name. This test was passing in Linux, 
> MacOS environments but ended up failing in Windows build systems.
> We ended up pushing a fix to not use `:` in the names.
> Open to other ideas as well!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to