gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r908942536
########## lucene/demo/src/java/org/apache/lucene/demo/facet/DistanceFacetsExample.java: ########## @@ -212,7 +212,26 @@ public static Query getBoundingBoxQuery( } /** User runs a query and counts facets. */ - public FacetResult search() throws IOException { + public FacetResult searchAllChildren() throws IOException { + + FacetsCollector fc = searcher.search(new MatchAllDocsQuery(), new FacetsCollectorManager()); + + Facets facets = + new DoubleRangeFacetCounts( + "field", + getDistanceValueSource(), + fc, + getBoundingBoxQuery(ORIGIN_LATITUDE, ORIGIN_LONGITUDE, 10.0), + ONE_KM, + TWO_KM, + FIVE_KM, + TEN_KM); + + return facets.getAllChildren("field"); + } + + /** User runs a query and counts facets. */ + public FacetResult searchTopChildren() throws IOException { Review Comment: OK thanks. I'm not opposed to demoing a `getTopChildren` example for what it's worth, but if we want to do that, let's try to come up with a real-world type use-case where a user might care about the "top" values? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org