shaie commented on code in PR #1001:
URL: https://github.com/apache/lucene/pull/1001#discussion_r917641237
##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -76,8 +92,12 @@ private int count(String field,
List<FacetsCollector.MatchingDocs> matchingDocs)
BinaryDocValues binaryDocValues =
DocValues.getBinary(hits.context.reader(), field);
- final DocIdSetIterator it =
-
ConjunctionUtils.intersectIterators(Arrays.asList(hits.bits.iterator(),
binaryDocValues));
+ DocIdSetIterator it = createIterator(hits);
Review Comment:
Yes I agree, for that reason I decided not to do it in [my
PR](https://github.com/apache/lucene/pull/1015). I don't think the base
collector helps us much at this point. It's not a lot of code duplication and
as you note it prevents us from optimizing the conjunction?
BTW, as I wrote on the issue I totally missed this PR when I pushed my PR.
Let's find a way to merge the two!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
