jpountz commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1188939297
I'm not familiar enough with the geo logic to comment on it but I left some comments on the Field and Query integration. I support Ignacio's suggestion of not trying to fold it into 9.3, it's a big (and exciting!) change. On the bw compat aspect, it would still be nice to retain some ability to make changes in the future, not only in `GeoEncodingUtils` but also changing the order of the data we include in the representation or adding more information to it? Codecs have a natural way to make changes to serialization in a backward-compatible way, but not things that we encode on top of codecs like encoding of binary doc values. Thinking out loud, should we prepend a version to the binary representation to have more freedom to make changes in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
