nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924694451
########## lucene/core/src/java/org/apache/lucene/document/XYShapeDocValuesBoundingBoxQuery.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.document; + +import static org.apache.lucene.geo.XYEncodingUtils.encode; + +/** + * Bounding Box query for {@link ShapeDocValuesField} representing {@link XYShape} + * + * @lucene.experimental + */ +final class XYShapeDocValuesBoundingBoxQuery extends BaseShapeDocValuesBoundingBoxQuery { + XYShapeDocValuesBoundingBoxQuery( + String field, + ShapeField.QueryRelation queryRelation, + float minX, + float maxX, + float minY, + float maxY) { + super(field, queryRelation, encode(minX), encode(maxX), encode(minY), encode(maxY)); Review Comment: The field should remain in encoded space and I have a change for the xy queries to operate in float space. Although it is unfortunately costly that the indexed geometries have to be decoded at query time. I wonder if we should figure out a more efficient way (which would impact indexed xy geometries as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
