msokolov commented on code in PR #1054: URL: https://github.com/apache/lucene/pull/1054#discussion_r940165941
########## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ########## @@ -248,7 +269,9 @@ private void run(String... args) throws Exception { if (docVectorsPath == null) { throw new IllegalArgumentException("missing -docs arg"); } - matchDocs = generateRandomBitSet(numDocs, selectivity); + if (prefilter) { Review Comment: FYI: I did a couple of runs with `filterSelectivity==0.1` and `prefilter` and no `prefilter`, and it seems to work OK - no errors and the prefilter case returned higher recall / lower latency for the same other settings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org