msokolov commented on code in PR #1054:
URL: https://github.com/apache/lucene/pull/1054#discussion_r949255426
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnFieldVectorsWriter.java:
##########
@@ -20,8 +20,12 @@
import java.io.IOException;
import org.apache.lucene.util.Accountable;
-/** Vectors' writer for a field */
-public abstract class KnnFieldVectorsWriter implements Accountable {
+/**
+ * Vectors' writer for a field
+ *
+ * @param <T> an array type; the type of vectors to be written
+ */
+public abstract class KnnFieldVectorsWriter<T> implements Accountable {
Review Comment:
well I guess this is the key bone of contention. TBH I have thrown up my
hands and just want whatever we can get merged that gets us the space savings.
There were objections to the other way, so I switched back to this way. This
way is more API-pure I guess, but requires more methods and API surface area. I
don't mind if we switch it again, but I'm probably not going to drive that
effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
