jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1091341226


##########
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java:
##########
@@ -489,6 +485,220 @@ public void mergeOneField(FieldInfo fieldInfo, MergeState 
mergeState) throws IOE
     }
   }
 
+  private HnswGraphBuilder<float[]> createFloatVectorHnswGraphBuilder(

Review Comment:
   I cant think of a good way to do this. HnswGraphBuilder  already uses 
generics and requires that the same generic be passed in for the 
RandomVectorValues. So I think some branching logic will be required no matter 
what. Did you have an idea for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to