jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1092337143
########## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java: ########## @@ -56,6 +56,8 @@ long apply(long v) { // Whether the search stopped early because it reached the visited nodes limit private boolean incomplete; + public static final NeighborQueue EMPTY_MAX_HEAP_NEIGHBOR_QUEUE = new NeighborQueue(1, true); Review Comment: You are right, I did not think about this. Given how much mutable state there is, I am wondering if it might just be better to get rid of this. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org