iverase commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1438631454
> For KeywordField and LongField/DoubleField we ended up adding an option to the ctor to store the field. This PR doesn't have this, but I'm unsure what should be the canonical representation of a geo point in stored fields. So maybe it's best to leave it to the app depending on whether they'd rather store it as a string, two doubles, or something else? I noticed that what I decided not to add it because as you said, there is no canonical representation of a point. I added javadocs to LatLonGeometry and the #newGeometryQuery function. In addition I tagged the method as expert so hopefully that overcomes the issues raised here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
