rmuir commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479280860
> Hi @rmuir, first of all, I deeply appreciate the time you are taking to help us on this issue, thank you for that. When I said "'ll leave the BoostAttribute discussion for another time" I meant today (I was on holiday last week and I had the chance to look at the code only today with @dantuzi and @ilariapet . I appreciate the javaDoc comments, but as also @dsmiley mentioned, I would like to understand practical reasons to avoid the usage of the BoostAttribute in other areas. It seems to me just a simple wrapper of a float value. Having a JavaDoc comment to restrict the usage of a public class is not ideal, but if you can elaborate we are more than happy to improve the contribution. The class is public due to the way attributes are implemented. AttributesImpl classes must be public, there's no way to make them package private! Does this make sense? It is in the search package for the fuzzy query to use for this reason, with lots of warnings in its documentation about the usage. The attribute is needed to manage the priority queue of fuzzy query's rewrite method. Because of this, there are some odd things about its behavior (e.g. allowing negative boosts). It is really not suitable for usage anywhere else in the system. please address my concern and don't ignore it. i'm -1 on this PR being merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
