gsmiller commented on code in PR #12194:
URL: https://github.com/apache/lucene/pull/12194#discussion_r1148140474
##########
lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java:
##########
@@ -82,6 +82,11 @@ public int advance(int target) throws IOException {
return doc;
}
+ @Override
Review Comment:
I wonder if we should override this for `range` also? Once you're positioned
inside the range, this would be `max` right?
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PostingsReader.java:
##########
@@ -479,6 +481,36 @@ private void refillDocs() throws IOException {
assert docBuffer[BLOCK_SIZE] == NO_MORE_DOCS;
}
+ @Override
+ public int peekNextNonMatchingDocID() throws IOException {
Review Comment:
I assume the idea would be to add this implementation to all five of the
`PostingsEnum` implementations in here? There's not anything fundamentally
preventing this from working when there are positions/payloads or when impacts
are requested right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
