jpountz commented on PR #12415: URL: https://github.com/apache/lucene/pull/12415#issuecomment-1623101984
To me a big question with this API is whether we should consider methods on the `DocIdStream` terminal or not. If we do this, then this may enable more optimizations later on, e.g. it would be legal to create such objects that are backed by an iterator. But on the other hand, you wouldn't be able to propage this optimization in a `MultiLeafCollector` since it would be illegal for each sub `LeafCollector` to consume the `DocIdStream` independently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
