benwtrent commented on issue #12945:
URL: https://github.com/apache/lucene/issues/12945#issuecomment-1856480501
This is interesting, that commit shouldn't have changed anything, just a
refactor.
I have confirmed I can repeat it (after several attempts), but cannot when
going to the commit before.
One suspect place is the `oldToNewOrdinal` mapping, but I just added a test
like this:
```
Map<Integer, Integer> originalOrdMap =
getOldToNewOrdinalMap(mergedVectorIterator);
assert oldToNewOrdinalMap.length == originalOrdMap.size();
for (int i = 0; i < oldToNewOrdinalMap.length; i++) {
assert oldToNewOrdinalMap[i] == originalOrdMap.get(i): "ordinal maps
should be equal " + oldToNewOrdinalMap + " vs " +
Arrays.toString(oldToNewOrdinalMap);
}
```
Where `getOldToNewOrdinalMap` is effectively copy-pasted from how it was
before and this does not trip when this test fails.
So, back to digging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
