shubhamvishu commented on PR #13001: URL: https://github.com/apache/lucene/pull/13001#issuecomment-1883422583
> In general this looks fine, although I think we should also work on remove some of those sleeps. For all others there should be an explanation, why the test needs sleeping. +1 to remove some to these usages. I didn't pursue since there are just too many of them. I think we could scope this PR to only add the api to forbidden ones and suppress all the usages and then follow up with a second pass or PR to remove those usages as much as possible. If that sounds good I could create a separate issue to reduce the existing usages(or we could use the same issue too). Let me know what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
