uschindler commented on PR #13133: URL: https://github.com/apache/lucene/pull/13133#issuecomment-1964649237
Hi, you can try it out. Two important comments: - In Java 21, MemorySegment is still a "preview" class, so it can't be used in any public method signatures. So actually to pass the MemorySegment around, you have to use `java.lang.Object` and cast it in the receiver. The coe compiled for Java 19-21 is stripping the preview flag, but the problem is that the public API in the proivider and the interface can't use the class. Sorry about this. Unfortunately this is still the case in Java 21, so it won't get better with Lucene 10 (which will bei Java 21 minimum). - Please implement the vector code in the "main20" folder against Java 20 (where the other vector code lives). As the vector API did not change between those versions, we don't need to extract the api for Java 20, so please revert the changes to API extractor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
