benwtrent commented on PR #13190: URL: https://github.com/apache/lucene/pull/13190#issuecomment-2004024374
@dweiss @mikemccand I am currently iterating on how to best make `RateLimitedIndexOutput` `MergePolicy` and `MergeRateLimiter` thread safe. Right now, it is all assumed that the interactions with all these are from the same thread, this obviously breaks when we add intra-merge parallelism. I was hoping y'all had some thoughts on how these should all work together with intra-merge parallelism? Is it enough to make these classes threadsafe and remove assertions? Do we want to somehow figure out if the ultimate calling thread was a MergeThread? (This is possible, but will require some wrangling on the tp-executor to keep track of which thread belongs where...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
