benwtrent commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2050914945
##########
lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java:
##########
@@ -236,10 +236,13 @@ private void scoreWindowUsingBitSet(
windowMatches.set(0, windowMax - windowBase);
} else {
DocIdSetIterator lead = iterators.get(0);
+ int intoBitSetBase = windowBase;
if (lead.docID() < windowBase) {
- lead.advance(windowBase);
+ intoBitSetBase = lead.advance(windowBase);
+ }
+ if (intoBitSetBase < windowMax) {
+ lead.intoBitSet(windowMax, windowMatches, intoBitSetBase);
Review Comment:
> The offset here is not where the iterator starts iteration, but a number
docs need to minus.
Gotcha! I will revert. I better understand now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
