gf2121 commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2050908893
##########
lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java:
##########
@@ -236,10 +236,13 @@ private void scoreWindowUsingBitSet(
windowMatches.set(0, windowMax - windowBase);
} else {
DocIdSetIterator lead = iterators.get(0);
+ int intoBitSetBase = windowBase;
if (lead.docID() < windowBase) {
- lead.advance(windowBase);
+ intoBitSetBase = lead.advance(windowBase);
+ }
+ if (intoBitSetBase < windowMax) {
+ lead.intoBitSet(windowMax, windowMatches, intoBitSetBase);
Review Comment:
Maybe my english is too poor to explaining this, but i think the default
impl of `intoBitset` is clear enough? You can see the `doc - offset` there.
https://github.com/apache/lucene/blob/4ac2d145acb150251001b6f8b454bb91b5e18f48/lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java#L205-L210
So your change is making docs in lead minus `intoBitSetBase`, but docs in
other iterators minus `windowBase`, which can not intersect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
