gf2121 commented on PR #14714: URL: https://github.com/apache/lucene/pull/14714#issuecomment-2913036055
Thanks for the suggestion! > It's a bit ugly to pass null as a HitQueue in the constructor of TopScoreDocCollector. Can we only keep method signatures on TopDocsCollector and move the current impls to some other class? FWIW passing a null PQ is mentioned in `TopScoreDocCollector`'s java doc https://github.com/apache/lucene/blob/6b3c3e4803dfe3edba75569e289fe492d8cc5cd2/lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java#L25-L28. I agree it is ugly to copy the large `topDocs(int start, int howMany)` so i was looking to extract PQ logics to a protected method, but i'm not sure if we should touch this public API class as this seems not to break the original intention of the design. In case you did not notice the java doc, i'd like to ask your suggestion again :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
