gf2121 commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2113866926
##########
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##########
@@ -73,23 +65,22 @@ public ScoreMode scoreMode() {
public LeafCollector getLeafCollector(LeafReaderContext context) throws
IOException {
final int docBase = context.docBase;
final ScoreDoc after = this.after;
- final float afterScore;
+ final int afterScore;
Review Comment:
I made them int because all scores in collector are only used to compare and
the only computation is `Math.nextUp` which needs to convert float to int :)
I'll revert these change as this does not seem to make sense to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
