jpountz commented on PR #15011:
URL: https://github.com/apache/lucene/pull/15011#issuecomment-3185884131

   One of Chris' comment helped me realize that we would still load filter 
matches into a `BitSet` with a flat scorer, which is undesirable. So I pushed a 
change that makes the loading into a bitset lazy, so that if a flat 
`KnnVectorsReader` only calls `AcceptDocs#iterator` but neither `#cost()` nor 
`#bits()` then we'd never load matches into a bitset. I had to restrict the 
contract of `AcceptDocs` so that it's illegal ta call `#cost()` nor `#bits()` 
after the iterator has advanced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to