uschindler commented on issue #15079: URL: https://github.com/apache/lucene/issues/15079#issuecomment-3197662471
I think we should remove the callback and lambda completely. The callback was only implemented to get the forward/backward reading of ints from the input using some positional API. It is not nice, see: https://github.com/apache/lucene/pull/12841 We should basically rewrite this to NOT use positional access. If we really need to, we should add a protected helper method in DataInput to help with reading from absolute positions relative to current position. Basically we need a (protected) method in IndexInput to read an integer relative to the current position but without changing position (which is updated at end). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
