sgup432 opened a new pull request, #15124:
URL: https://github.com/apache/lucene/pull/15124

   
   
   ### Description
   
   Related issue - https://github.com/apache/lucene/issues/15097
   
   Instead of using the default 1024 bytes for query size, we try to use 
RamUsageEstimator to calculate approx size. As seen in above issues, using 1024 
as a default can cause issues(like heap exhaustion) due to underestimation, and 
even cause overestimation leading to fewer queries getting cached.
   
   `RamUsageEstimator.sizeOf()` is usually pretty fast, I made a sample 
BooleanQuery with 15 clauses with a size of around 3kb. It took around 14959ns 
to calculate its size via `RamUsageEstimator.sizeOf()`.
   
   
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to