cwperks commented on code in PR #15124:
URL: https://github.com/apache/lucene/pull/15124#discussion_r2300592636


##########
lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java:
##########
@@ -1062,6 +1063,38 @@ public void testBooleanQueryCachesSubClauses() throws 
IOException {
     dir.close();
   }
 
+  public void testCacheRamBytesWithALargeTermQuery() throws IOException {
+    Directory dir = newDirectory();

Review Comment:
   FYI I recently received a comment to use try-with-resources for these 
closeable resources: 
https://github.com/apache/lucene/pull/15120#discussion_r2298924395
   
   It can be updated to:
   
   ```
   try (Directory dir = newDirectory(); RandomIndexWriter w = new 
RandomIndexWriter(random(), dir)) {
       ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to