javanna commented on PR #15125: URL: https://github.com/apache/lucene/pull/15125#issuecomment-3223294132
Hey, thanks for fixing this! I checked out your branch and verified the fix, yet I am not very familiar with `IndexingChain`, hence I have some basic questions. To make sure I understand the issue 100%: when there is an inconsistency, an IAE is thrown as part of `initializeFieldInfo`, which though leaves the `PerField` instance without field info set, which when accessed later causes problems, especially when consulting the doc values type to sort the segments if index sorting is enabled. Correct? Are there other scenarios where the same could happen, that a `PerField` instance has no field info set to it, and is index sorting the only place where this causes issues? This code seems pretty delicate and it seems like things may go wrong in other ways, but I can't tell exactly. Your fix handles the null field info by checking the doc values writer. Could you expand on why checking docValuesWriter instead of checking field info directly? Are there circumstances where you'd expect the former to be null but the latter non null? Do we have a chance to consider a more comprehensive fix like delay adding the `PerField` to the `perFieldHash` until field info is set to it? I can't tell if there may be side effects of that though. Last but not least: with your fix, what is the effect on index sorting of returning null when field info is null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
