benwtrent commented on code in PR #15187:
URL: https://github.com/apache/lucene/pull/15187#discussion_r2352449825
##########
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##########
@@ -191,7 +192,7 @@ public long ramBytesUsed() {
}
/** VectorReader that can wrap multiple delegate readers, selected by field.
*/
- public static class FieldsReader extends KnnVectorsReader implements
HnswGraphProvider {
+ private static class FieldsReader extends KnnVectorsReader implements
HnswGraphProvider {
Review Comment:
Since the covering class is `lucene.experimental` I think this will be OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
