thecoop commented on code in PR #15187:
URL: https://github.com/apache/lucene/pull/15187#discussion_r2387797553
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java:
##########
@@ -49,6 +50,14 @@ protected KnnVectorsReader() {}
*/
public abstract void checkIntegrity() throws IOException;
+ /**
+ * If this reader wraps another for {@code field}, return the underlying
reader, else return
+ * {@link Optional#empty}
+ */
+ public Optional<KnnVectorsReader> unwrapReaderForField(String field) {
+ return Optional.empty();
Review Comment:
There's various tests that throw if the reader is not unwrapped, and there's
other `unwrap` methods that return `null` if its not wrapped. But looking at
it, all the prod uses just fallback to the original reader. I'll change it to
return `this` then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
