vigyasharma commented on PR #15233:
URL: https://github.com/apache/lucene/pull/15233#issuecomment-3353553261
Thanks for fixing this test, @VivekKumarNeu !
> I believe this condition:
> `if (random().nextInt(31) == 0) { writer.commit(); }`
> will only work for a specific time. If this is not true, we are without an
index, and this error occurs.
That seems to be the case. For the specific seed which fails, the test never
does a commit so the index doesn't exist. It's interesting, the odds of this
happening should be very low (~0.01%). After indexing every doc, there's a 1/31
probability that we commit. And we index over 256 docs! Anyway, I think your
fix of doing one final commit before we read this index makes sense.
Your actual fix is just a one line change, but this PR shows a lot of diffs
from main. Can you fix that before we approve and merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
