msfroh commented on PR #15233:
URL: https://github.com/apache/lucene/pull/15233#issuecomment-3353711888

   >The test as it was would also test the case where there are some 
uncommitted updates that would be flushed when the reader is opened (I think)
   
   In this case, the reader isn't being opened from the writer, but rather gets 
opened against the directory. So, the pending changes wouldn't get flushed 
AFAIK. (So the deletes 
   
   It's worth noting that `doTestSortedSetVsStoredFields` and 
`doTestSortedVsStoredFields` *do* open the reader from the writer. So, I think 
the most consistent thing is to do the same in 
`doTestSortedNumericsVsStoredFields`. 
   
   @VivekKumarNeu -- can you please confirm that replacing the 
`DirectoryReader.open` lines with `writer.getReader()` fixes the issue as well?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to